AG-11612 - Fix series per data with distinct categories. #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alantreadway
changed the title
alantreadway
force-pushed
the
ag-11612/fix-series-per-data-with-distinct-categories
branch
2 times, most recently
from
951ac98 to
9999e5b
Compare
alantreadway
commented
Jan 30, 2025
There was a problem hiding this comment.
This is the actual case fixed by this change.
alantreadway
commented
Jan 30, 2025
alantreadway
commented
Jan 30, 2025
There was a problem hiding this comment.
Reviewed with David + Mana for correctness - new rendering is now correct.
alantreadway
force-pushed
the
ag-11612/fix-series-per-data-with-distinct-categories
branch
from
16e9eeb to
c5b080b
Compare
lsjroberts
reviewed
Jan 31, 2025
| @@ -387,6 +389,17 @@ export class DataModel< | |||
| break; | |||
| } | |||
| } | |||
|
|
|||
| if (!!this.opts.groupByKeys || this.opts.groupByFn != null || this.opts.groupByData) { | |||
There was a problem hiding this comment.
nit: sonarqube doesn't like !!
There was a problem hiding this comment.
I actually ended up with this whilst try to address other SonarCloud issues, and I'm not seeing a warning for the current expression - so 🤷
iMoses
approved these changes
Jan 31, 2025
lsjroberts
approved these changes
Jan 31, 2025
packages/ag-charts-website/src/content/docs/benchmarks/_examples/summary/data.ts
Outdated
Show resolved
Hide resolved
alantreadway
deleted the
ag-11612/fix-series-per-data-with-distinct-categories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-11612