AG-13737 Zoom multitouch #3336
Open
AG-13737 Zoom multitouch #3336
+514
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
force-pushed
the
AG-13737/zoom_multitouch
branch
5 times, most recently
from
54b7271 to
26c4d2d
Compare
olegat
requested review from
alantreadway,
rmc-software and
a team
as code owners
alantreadway
requested changes
Jan 13, 2025
There was a problem hiding this comment.
We don't typically put implementation docs in the repo - please use Confluence for this, and add a link in the source code.
olegat
force-pushed
the
AG-13737/zoom_multitouch
branch
2 times, most recently
from
5f655ab to
87919d3
Compare
olegat
force-pushed
the
AG-13737/zoom_multitouch
branch
4 times, most recently
from
b8861a2 to
28b5afd
Compare
olegat
force-pushed
the
AG-13737/zoom_multitouch
branch
from
28b5afd to
3d57411
Compare
|
Snapshots automatically updated, please review before merge: diff |
This seems to work as intended on the X-axis. The Y-axis has an issue at the moment (perhaps because the direction of the screen and normalised Y-values is reversed). I'll write up my paper math notes once I've got a working solution.
The two-fingers zoompan gesture on the X-axis was working only if the touch[0] was on the left and touch[1] was on the right. When the positioning of touch[0] and touch[1] was reversed, so too was the gesture. Therefore, ensure that x0 <= x1 and a0 <= a1.
There were two bugs: 1) We don't need to flip the normalised Y value (N - y) 2) We weren't flipping the screen Y value in 'touchstart'
The variable names `f` and `g` look too much like functions instead of variables.
olegat
force-pushed
the
AG-13737/zoom_multitouch
branch
from
3d57411 to
7abe903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13737