Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialIP removed from API #71

Merged
merged 2 commits into from
Dec 23, 2024
Merged

initialIP removed from API #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80d2fb8
Remove initial ip from Account
bessone Dec 9, 2024
720a7b6
No more initial ip in account constructor
bessone Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ public function getAccount(): Account
$data = json_decode((string)$response->getBody(), true);
$accountURL = $response->getHeaderLine('Location');
$date = (new \DateTime())->setTimestamp(strtotime($data['createdAt']));
return new Account($data['contact'], $date, ($data['status'] == 'valid'), $data['initialIp'], $accountURL);
return new Account($data['contact'], $date, ($data['status'] == 'valid'), $accountURL);
}

/**
Expand Down
17 changes: 0 additions & 17 deletions src/Data/Account.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ class Account
*/
protected $isValid;

/**
* @var
*/
protected $initialIp;

/**
* @var string
*/
Expand All @@ -36,17 +31,14 @@ class Account
* @param array $contact
* @param \DateTime $createdAt
* @param bool $isValid
* @param string $initialIp
* @param string $accountURL
*/
public function __construct(
array $contact,
\DateTime $createdAt,
bool $isValid,
string $initialIp,
string $accountURL
) {
$this->initialIp = $initialIp;
$this->contact = $contact;
$this->createdAt = $createdAt;
$this->isValid = $isValid;
Expand Down Expand Up @@ -89,15 +81,6 @@ public function getContact(): array
return $this->contact;
}

/**
* Return initial IP
* @return string
*/
public function getInitialIp(): string
{
return $this->initialIp;
}

/**
* Returns validation status
* @return bool
Expand Down