[WIP] DistinctErrorLog lock free. #325
Open
+58
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pveentjer
commented
Feb 4, 2025
| import static org.agrona.BitUtil.SIZE_OF_INT; | ||
| import static org.agrona.BitUtil.SIZE_OF_LONG; | ||
| import static org.agrona.BitUtil.align; | ||
| import static org.agrona.BitUtil.*; |
There was a problem hiding this comment.
Intellij and its autoformatting.. This will be fixed if we decide to merge this PR.
As long as their are existing observations, the implementation is lock free. Also the last observation timestamp is now guaranteed to be monotonic increasing.
pveentjer
force-pushed
the
improvement/DistinctErrorLog-lockfee
branch
from
5abc6cc to
86ab896
Compare
pveentjer
commented
Feb 4, 2025
| @@ -157,38 +157,83 @@ public Charset charset() | |||
| */ | |||
| public boolean record(final Throwable observation) | |||
| { | |||
| final long timestampMs; | |||
| DistinctObservation distinctObservation; | |||
| final long timestampMs = clock.time(); | |||
There was a problem hiding this comment.
I think the above logic should be moved into the updateLastObservationTimestamp method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as their are existing observations, the implementation is lock free.
Also the last observation timestamp is now guaranteed to be monotonic increasing.
Note: I have not updated the test yet.