Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Added Input Validation tests and Imroved Modularity of code #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xatuke
Copy link

@xatuke xatuke commented Dec 5, 2019

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes #144

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality)

GIF:
20191205_144844

How Has This Been Tested?

They Don't break the app, yet :)

Checklist
  • tests are included

@Lavanyagaur22 Lavanyagaur22 self-requested a review December 5, 2019 10:31
@Lavanyagaur22
Copy link
Collaborator

@crowded-geek Good work! Keep it up 👍
Again not merging this because still some instances of the tasks are left. But I will surely do it after some time. Now you can actually work on issue no #170 because working on this issue will give you a pretty good idea of how the library is actually working. Task-related to it would soon be published and would be visible on your GCI dashboard. You can start working on this and claim the task after that. So that after you understand the library you can write the unit tests for it as well.

@xatuke
Copy link
Author

xatuke commented Dec 5, 2019

@Lavanyagaur22 Okay, I'll work on #170 but before that I need to complete and submit some other tasks after them i'll do #170 :) Thanks ;)

@harshithdwivedi harshithdwivedi added the can-be-merged This PR can be merged label Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
can-be-merged This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write unit tests for the sample app.
3 participants