Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Github Workflow to check formatting with black and reformat files #321

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add a Github Workflow to check formatting with black and reformat files #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
774f414
Add a Github workflow to lint files with black
Sep 12, 2024
86cea30
Reformatted __init__.py to test workflow
Sep 12, 2024
213d747
Add a workflow step to determine changed files
Sep 13, 2024
2005d74
Adding a requirements.txt as needed by Github Workflows
Sep 13, 2024
d567d5d
Add fetch-depth to be able to determine the list of files changed
Sep 13, 2024
20d36e6
Reformatted with black
Sep 13, 2024
24708a4
Simplify workflow
Sep 13, 2024
324fbf8
Only lint py files
Sep 13, 2024
5f190ce
Simplify workflow to lint all files
Sep 13, 2024
d85cf6d
Reformat files to pass black linting
Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Python Lint with Black

on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
python-version:
- "3.12"
- "3.11"
- "3.10"
- "3.9"
- "3.8"
- "3.7" # The oldest version supported by Github Actions

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: pip

- name: Install black
run: pipx install black

- name: Lint with Black
run: black --check ebooklib/
23 changes: 12 additions & 11 deletions ebooklib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,15 @@
ITEM_SMIL = 11

# EXTENSION MAPPER
EXTENSIONS = {ITEM_IMAGE: ['.jpg', '.jpeg', '.gif', '.tiff', '.tif', '.png'],
ITEM_STYLE: ['.css'],
ITEM_VECTOR: ['.svg'],
ITEM_FONT: ['.otf', '.woff', '.ttf'],
ITEM_SCRIPT: ['.js'],
ITEM_NAVIGATION: ['.ncx'],
ITEM_VIDEO: ['.mov', '.mp4', '.avi'],
ITEM_AUDIO: ['.mp3', '.ogg'],
ITEM_COVER: ['.jpg', '.jpeg', '.png'],
ITEM_SMIL: ['.smil']
}
EXTENSIONS = {
ITEM_IMAGE: [".jpg", ".jpeg", ".gif", ".tiff", ".tif", ".png"],
ITEM_STYLE: [".css"],
ITEM_VECTOR: [".svg"],
ITEM_FONT: [".otf", ".woff", ".ttf"],
ITEM_SCRIPT: [".js"],
ITEM_NAVIGATION: [".ncx"],
ITEM_VIDEO: [".mov", ".mp4", ".avi"],
ITEM_AUDIO: [".mp3", ".ogg"],
ITEM_COVER: [".jpg", ".jpeg", ".png"],
ITEM_SMIL: [".smil"],
}
Loading