Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] stop segmenters changing state in predict #2526

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Feb 3, 2025

several segmenters failed the test that predict does not change the state. This PR fixes that. All have fit_is_empty = True. The choice is to not store data or to introduce a fit method. For these three

"FLUSSSegmenter": ["check_non_state_changing_method"],
"InformationGainSegmenter": ["check_non_state_changing_method"],
"GreedyGaussianSegmenter": ["check_non_state_changing_method"],

just stopped storing data not used anywhere.
edit: will leave clasp, used in notebooks

@aeon-actions-bot aeon-actions-bot bot added maintenance Continuous integration, unit testing & package distribution segmentation Segmentation package testing Testing related issue or pull request visualisation Visualisation module labels Feb 3, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#0e8a16}{\textsf{segmentation}}$, $\color{#2C2F20}{\textsf{testing}}$, $\color{#FBCA04}{\textsf{visualisation}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Long time I looked at segmentation) For GG and IGTS changes should be OK, but for Fluss, if you change the X you give in predict it won't change the prediction, it feels weird. Couldn't you just remove the self storing of found_cps and the others to avoid the state change in predict ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution segmentation Segmentation package testing Testing related issue or pull request visualisation Visualisation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants