-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] stop segmenters changing state in predict #2526
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Long time I looked at segmentation) For GG and IGTS changes should be OK, but for Fluss, if you change the X
you give in predict it won't change the prediction, it feels weird. Couldn't you just remove the self storing of found_cps
and the others to avoid the state change in predict ?
several segmenters failed the test that predict does not change the state. This PR fixes that. All have fit_is_empty = True. The choice is to not store data or to introduce a fit method. For these three
just stopped storing data not used anywhere.
edit: will leave clasp, used in notebooks