-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] n_jobs parameter usage improved #2515
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a fan of these changes, does not solve the issue IMO. I would rather _n_jobs
be removed and ensure estimators with "capability:multithreading" are using check_n_jobs
.
Attributes | ||
---------- | ||
metadata_ : dict | ||
Stores metadata about the input data characteristics seen during fitting. | ||
Contains keys like: | ||
- 'multivariate': whether data has multiple channels | ||
- 'missing_values': presence of missing values | ||
- 'unequal_length': whether time series have varying lengths | ||
- 'n_cases': number of time series instances | ||
- 'n_channels': number of data channels | ||
- 'n_timepoints': number of timepoints (None if unequal length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it belongs in the class docstring rather than here?
Reference Issues/PRs
Contributes to #1886.
What does this implement/fix? Explain your changes.
Improves handling of n_jobs ; standarizes n_job validation. Documentation of init class parameters improved.
Does your contribution introduce a new dependency? If yes, which one?
No new dependencies. Uses existing check_n_jobs() utility from aeon.
Any other comments?
No
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access