update on same set of videos issue (small feature update) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On deployment , i noticed same set of videos were returned on each reload because of hardcoded param values like "date"
This change will broaden the set of videos returned on each reload by ->
changing the sorting order from "date" to a mix of "date" , "viewCount" "rating" etc on random and this change will not reflect on channelDetails page because of the extra parameter taken as an arguement so channelDetails page will only have videos ordered by "date"
changing the country codes at random will also generate different set of videos on our feed broadening our pool but this can be considered as an optional change and can be changed as per liking of the mainters
please ignore a few changes on readme.md , it was unintentional