Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Proxy support #85

Merged
merged 6 commits into from
Oct 3, 2024
Merged

feat: Proxy support #85

merged 6 commits into from
Oct 3, 2024

Conversation

sandeep-paliwal
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal commented Oct 1, 2024

Swagger client was not using the set proxy.
Added option to use networking lib proxyFetch when proxy is set.

Description

Related Issue

adobe/aio-cli-plugin-console#218

Motivation and Context

How Has This Been Tested?

Manual Proxy setup and test
unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (601a3b4) to head (9cea668).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          530       533    +3     
  Branches        15        15           
=========================================
+ Hits           530       533    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeep-paliwal sandeep-paliwal marked this pull request as ready for review October 1, 2024 06:18
src/index.js Outdated Show resolved Hide resolved
@sandeep-paliwal sandeep-paliwal merged commit 5b340db into master Oct 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants