Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: "Skip to transcript" button spacing (fixes #312) #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: "Skip to transcript" button spacing (fixes #312) #313

wants to merge 1 commit into from

Conversation

swashbuck
Copy link
Contributor

Fix #312

Fix

  1. Ensure "Skip to transcript" button does not take up space until in focus
  2. Add bottom margin to button when visible

Testing

  1. Using keyboard navigation, tab until you come to a "Skip to transcript" button.

@swashbuck swashbuck self-assigned this Jan 20, 2025
@swashbuck swashbuck added the bug label Jan 20, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@swashbuck swashbuck

Labels
bug
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Skip to transcript" button takes up space when hidden, lacks bottom margin
2 participants
@swashbuck @cahirodoherty-learningpool