Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Skip to transcript" button takes up space when hidden, lacks bottom margin #312

Open
swashbuck opened this issue Jan 20, 2025 · 0 comments · May be fixed by #313
Open

"Skip to transcript" button takes up space when hidden, lacks bottom margin #312

swashbuck opened this issue Jan 20, 2025 · 0 comments · May be fixed by #313
Assignees
Labels

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Jan 20, 2025

Subject of the issue

Issue 1

The hidden "Skip to Transcript" button is taking up vertical space. This appears directly underneath the instruction text.

If we change the button to display: block, the space is removed.

Issue 2

There is no bottom margin on the "Skip to Transcript" button when it has focus. Therefore, it sits flush on top of the media widget.

Suggested fix

  .media__skip-to-transcript {
    margin-bottom: @item-margin;

    &:not(:focus-visible) {
      display: block;
    }
  }

Your environment

  • Media 6.7.4
@swashbuck swashbuck added the bug label Jan 20, 2025
@swashbuck swashbuck self-assigned this Jan 20, 2025
@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board Jan 20, 2025
@swashbuck swashbuck changed the title "Skip to Transcript" button takes up space when hidden, lacks bottom margin "Skip to transcript" button takes up space when hidden, lacks bottom margin Jan 20, 2025
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Reviewing
Development

Successfully merging a pull request may close this issue.

1 participant