-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Natural dtype for rotation matrices #81
base: master
Are you sure you want to change the base?
Conversation
25bd63c
to
00476d4
Compare
I have a feeling those test failures are related to #77 |
I think any of the Lastly, update the CHANGELOG and add yourself to the contributors in the README if you wish =) There are other features we need to include in the CHANGELOG since the last release, but don't let that stop you. |
Anyone else want to chime in on this one? @foohyfooh? |
The other
As for the creation of a rotation matrix from axis-angle, I would also enforce that Euler angles and quaternions be float. Currently, the >>> import pyrr
>>> e = pyrr.euler.create(1,2,3)
>>> e
array([1, 2, 3])
>>> e.dtype
dtype('int64')
>>> q = pyrr.quaternion.create(1,2,3,4)
>>> q
array([1, 2, 3, 4])
>>> q.dtype
dtype('int64')
>>> Seems related to #35 |
That's the thing. If you want to enable user laziness, then you need to update all the interfaces to be more intelligent. So many API functions need to be touched. |
Tentative PR for #80
This could maybe be applied to other functions. I haven't checked yet. Any hints welcome.