Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waveshare ESP32-S3 Zero #412

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Add Waveshare ESP32-S3 Zero #412

merged 3 commits into from
Oct 22, 2024

Conversation

bill88t
Copy link
Contributor

@bill88t bill88t commented Oct 1, 2024

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

This checklist items that are not applicable to your PR can be deleted.


Description of Change

A board already ported to CircuitPython. Got it today, thankfully I don't need to go through the pid-aquiring process.

@bill88t
Copy link
Contributor Author

bill88t commented Oct 1, 2024

The neopixel has red and green inverted, added support for that with an #ifdef.

@bill88t bill88t marked this pull request as ready for review October 1, 2024 22:14
@bill88t
Copy link
Contributor Author

bill88t commented Oct 22, 2024

Is there an issue with the PR?

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank you

@hathach hathach merged commit 2e553ad into adafruit:master Oct 22, 2024
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants