-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make output for results with zero columns standard-compliant #1749
base: master
Are you sure you want to change the base?
Conversation
TODO: add unit test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
+ Coverage 89.95% 89.97% +0.02%
==========================================
Files 395 395
Lines 37651 37654 +3
Branches 4234 4234
==========================================
+ Hits 33869 33880 +11
+ Misses 2487 2478 -9
- Partials 1295 1296 +1 ☔ View full report in Codecov by Sentry. |
Conformance check passed ✅No test result changes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much
For queries with zero columns (e.g., |
For queries with zero columns (e.g.,
SELECT * WHERE { <s> <p> <o> }
), the results were not fully standard-compliant. In particular, only the empty header row was output fortext/tab-separated-values
andtext/csv
, but never any additional empty rows. This is now fixed. Fixes #1745