Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal templates UI #4308

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jfdoming
Copy link
Contributor

@jfdoming jfdoming commented Feb 6, 2025

Round 2 of prototyping a goal template UI (the previous PR can't be reopened sadly). Addressed a bit of feedback from that PR.

@jfdoming jfdoming added the do not merge Don't merge this!!! label Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit b91c630
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67a466c24b787e0008b1e44f
😎 Deploy Preview https://deploy-preview-4308.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 6.79 MB → 7.37 MB (+589.47 kB) +8.48%
Changeset
File Δ Size
node_modules/lodash/lodash.js 🆕 +547.05 kB 0 B → 547.05 kB
src/components/budget/goals/EditTemplate.tsx 🆕 +15.23 kB 0 B → 15.23 kB
src/components/budget/goals/reducer.ts 🆕 +3.19 kB 0 B → 3.19 kB
src/components/modals/BudgetAutomationsModal.tsx 🆕 +2.66 kB 0 B → 2.66 kB
src/components/budget/goals/GoalButton.tsx 🆕 +1.38 kB 0 B → 1.38 kB
src/components/budget/goals/constants.ts 🆕 +392 B 0 B → 392 B
src/components/budget/goals/actions.ts 🆕 +159 B 0 B → 159 B
node_modules/lodash/lodash.js?commonjs-module 🆕 +27 B 0 B → 27 B
locale/de.json 📈 +18.37 kB (+23.45%) 78.37 kB → 96.74 kB
src/components/settings/Experimental.tsx 📈 +493 B (+12.62%) 3.81 kB → 4.29 kB
src/hooks/useFeatureFlag.ts 📈 +33 B (+10.25%) 322 B → 355 B
src/components/budget/SidebarCategory.tsx 📈 +344 B (+6.49%) 5.17 kB → 5.51 kB
src/style/styles.ts 📈 +135 B (+2.90%) 4.55 kB → 4.68 kB
src/components/Modals.tsx 📈 +146 B (+0.84%) 17.04 kB → 17.18 kB
src/components/util/GenericInput.jsx 📈 +38 B (+0.59%) 6.28 kB → 6.32 kB
src/components/modals/EditRuleModal.jsx 📉 -134 B (-0.32%) 41.29 kB → 41.16 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 4.29 MB → 4.85 MB (+571.48 kB) +13.02%
static/js/de.js 78.37 kB → 96.74 kB (+18.37 kB) +23.45%

Smaller

Asset File Size % Changed
static/js/ReportRouter.js 1.59 MB → 1.59 MB (-392 B) -0.02%

Unchanged

Asset File Size % Changed
static/js/uk.js 111.11 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/wide.js 102.8 kB 0%
static/js/nl.js 83.87 kB 0%
static/js/en-GB.js 99.33 kB 0%
static/js/en.js 99.34 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/pt-BR.js 103.29 kB 0%
static/js/narrow.js 84.94 kB 0%
static/js/AppliedFilters.js 10.52 kB 0%

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@youngcw
Copy link
Member

youngcw commented Feb 6, 2025

Looks good so far. One thing that maybe you could keep in mind is that it would be nice to have a central place to view and edit templates. So this new modal to make templates should be ready to be used both from the budget page and a goals list page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP do not merge Don't merge this!!!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants