Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Update to detray version 0.87.0 #805

Merged
merged 3 commits into from
Jan 22, 2025
Merged

ref: Update to detray version 0.87.0 #805

merged 3 commits into from
Jan 22, 2025

Conversation

niermann999
Copy link
Contributor

Update to detray version 0.87.0 and algebra plugins version 0.26.2, which mainly contain the full algebra templating of detray

@niermann999 niermann999 force-pushed the ref-update-detray branch 3 times, most recently from 83e5a91 to e20c4fd Compare December 19, 2024 17:53
krasznaa
krasznaa reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the overall design of the changes. I think the code looks good like this.

Just some technical comments. 😉

core/include/traccc/finding/combinatorial_kalman_filter_algorithm.hpp Outdated Show resolved Hide resolved
core/include/traccc/finding/combinatorial_kalman_filter_algorithm.hpp Outdated Show resolved Hide resolved
core/include/traccc/fitting/kalman_fitting_algorithm.hpp Outdated Show resolved Hide resolved
plugins/algebra/array/include/traccc/plugins/algebra/array_definitions.hpp Show resolved Hide resolved
stephenswat
stephenswat approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@niermann999 niermann999 force-pushed the ref-update-detray branch 6 times, most recently from b63d9c0 to ed9e4a7 Compare January 21, 2025 17:02
@niermann999 niermann999 force-pushed the ref-update-detray branch 2 times, most recently from f2abd34 to eeda5d3 Compare January 21, 2025 19:05
@niermann999
Copy link
Contributor Author

I also removed some detray::get_data calls now that are not needed

@stephenswat stephenswat enabled auto-merge (squash) January 22, 2025 09:41
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
10.7% Duplication on New Code

See analysis details on SonarQube Cloud

@stephenswat stephenswat merged commit 8db2c76 into acts-project:main Jan 22, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa left review comments

@beomki-yeo beomki-yeo Awaiting requested review from beomki-yeo

@stephenswat stephenswat Awaiting requested review from stephenswat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niermann999 @stephenswat @krasznaa