feat: Add surface finder container to detector #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-make-accel-callable
branch
from
00f057c to
2c17339
Compare
|
The device side code does not yet work, but could you have a first look, please @beomki-yeo ? |
Ok, nvm. I need to roll a few things back. I am going to convert it into a draft again |
|
Ok, I will rebase and comment the cuda integration in the detector until we have a container that runs on device. Otherwise, I think this can stay the way it is now |
beomki-yeo
reviewed
Aug 16, 2022
beomki-yeo
approved these changes
Aug 18, 2022
|
There's still some build failures it seems.. |
|
Is this PR going to be rewritten after #303 ? |
niermann999
force-pushed
the
feat-make-accel-callable
branch
2 times, most recently
from
29af60e to
3d11721
Compare
detector grids inside (Only works on host so far). Apart from that, a brute force surface finder is also added. All can be accessed with custom type IDs, the same way as it is implemented for the masks. The surface finders can be called from the navigator using a neighborhood_kernel, but for now they always return the complete volume range, until the zone function of the grid is properly adapted. The grids are built in the toy geometry in dedicated functions and the detector now uses the custom bin_association to fill surfaces into grids. For now, the grid building is commented out until we have a working implementation of a grid container in a subsequent PR. Further small changes: - The previous surface_finder class is no longer used in favour of the tuple_array_container. All typedefs are done by the type_registry. - The type ID enums are no longer implicitly convertible to an index for type safety, but can be converted, if necessary. - Where possible, all code that contains 'unrolling' has been put into functors and is called in the tuple_container. - The volume index is now fixed to dindex, since this is unlikely to change. - The surface finder link has been removed from the masks, since it is now part of the volume class. - Some minor refactoring (e.g. the edge types are renamed to volume_link for clarity). - More elaborate comments on some geometry classes and their template arguments. - For some reason, the usage of the detector memory resource in the navigator buffer broke, so they get an external resource now.
niermann999
force-pushed
the
feat-make-accel-callable
branch
from
144268e to
e856af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the tuple array container to the detector and puts the toy detector grids inside (Only works on host so far). Apart from that, a brute force surface finder is also added. All can be accessed with custom type IDs, the same way as it is implemented for the masks. The surface finders can be called from the navigator using a
neighborhood_kernel, but for now they always return the complete volume range, until thezonefunction of the grid is properly adapted. The grids are built in the toy geometry in dedicated functions and the detector now uses the custombin_associationto fill surfaces into grids. For now, the grid building in thecsv_io.hppis commented out until properly implemented in a subsequent PR.Further small changes:
surface_finderclass is no longer used in favour of thetuple_array_container. All typedefs are done by thetype_registryenums are no longer implicitly convertible to an index for type safety, but can be converted, if necessarytuple_container.dindex, since this is unlikely to changevolume_linkfor clarity)Edit: For some reason the usage of the detector vecmem resource broke in the navigator jagged vector buffer, so it gets an external host accessible resource now...