fix: Eigen Identity matrix and Vc/SMatrix matrix getter and hide arithmetic operators in algebra namespace #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-some-fixes
branch
2 times, most recently
from
d1ee45d to
04d9f3d
Compare
|
niermann999
force-pushed
the
ref-some-fixes
branch
from
04d9f3d to
e2a9a17
Compare
niermann999
changed the title
beomki-yeo
reviewed
Dec 5, 2024
beomki-yeo
reviewed
Dec 5, 2024
niermann999
force-pushed
the
ref-some-fixes
branch
from
e2a9a17 to
e60d357
Compare
beomki-yeo
approved these changes
Dec 5, 2024
niermann999
changed the title
krasznaa
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Apart from the formatting issues, this looks fine to me.
Just as a comment: Instead of the using namespace algebra statements, I myself would've probably put the common test code into let's say an algebra::test:: namespace.
But since it's testing code, I don't actually care a whole lot about the exact formalism...
niermann999
force-pushed
the
ref-some-fixes
branch
2 times, most recently
from
8500c2f to
178608a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Eigen Identity matrix in the transform class leads to invalid instructions in CUDA. Also fixes small issues in the matrix getters of the Vc and SMatrix plugins.
Also moves the arithmetic operators of the cmath plugin to the algebra namespace, since they were picked up in ACTS builds by Eigen types