Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Write correct tracks to file for refitting, prevent FPE #3999

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
+10 −10
Open

fix: Write correct tracks to file for refitting, prevent FPE #3999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
30d4564
update
benjaminhuth Dec 19, 2024
52ed96f
update
benjaminhuth Dec 19, 2024
abd3155
update
benjaminhuth Dec 19, 2024
262c153
update
benjaminhuth Dec 19, 2024
3e34e7e
revert cov inflation, fix kf outputs
benjaminhuth Dec 19, 2024
26fbffa
update hashes
benjaminhuth Dec 19, 2024
b84b2cd
Merge branch 'main' into fix/gsf-refit-wrong-outputs
kodiakhq[bot] Dec 20, 2024
c64b10a
Merge branch 'main' into fix/gsf-refit-wrong-outputs
benjaminhuth Jan 22, 2025
6b809ef
update references
benjaminhuth Jan 22, 2025
8bc4849
add FPE mask
benjaminhuth Jan 23, 2025
4ed4239
reset reference for GSF refitting
benjaminhuth Jan 23, 2025
4a4c92f
update
benjaminhuth Jan 24, 2025
5bf11c7
improve fix and add test
benjaminhuth Jan 27, 2025
9a1839e
Merge branch 'main' into fix/gsf-refit-wrong-outputs
benjaminhuth Jan 28, 2025
e4be50b
update refs
benjaminhuth Jan 29, 2025
c366d69
Merge branch 'main' into fix/gsf-refit-wrong-outputs
kodiakhq[bot] Jan 29, 2025
ab9b7cf
update
benjaminhuth Jan 29, 2025
630c22c
update
benjaminhuth Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified CI/physmon/reference/trackrefitting_gsf/performance_trackrefitting.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/trackrefitting_kf/performance_trackrefitting.root
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions Examples/Io/Root/src/RootTrackSummaryWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,9 @@ ProcessCode RootTrackSummaryWriter::writeT(const AlgorithmContext& ctx,
param[i] = parameter[i];
}

const auto& covariance = track.covariance();
for (unsigned int i = 0; i < Acts::eBoundSize; ++i) {
error[i] = std::sqrt(covariance(i, i));
double variance = getCov(i, i);
error[i] = variance >= 0 ? std::sqrt(variance) : NaNfloat;
}
}

Expand Down
4 changes: 2 additions & 2 deletions Examples/Python/tests/root_file_hashes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ test_exatrkx[gpu-onnx]__performance_track_finding.root: 9090de10ffb1489d3f1993e2
test_exatrkx[gpu-torch]__performance_track_finding.root: 6b658fa22c7532e082eaab7aa4b71b852f1c324adcc59d1156aff45124b222d9
test_ML_Ambiguity_Solver__performance_finding_ambiML.root: 166dd8bb189097c4957b7b02c04c41267868d72d9a08c4bb892985b06849cb76
test_refitting[generic]__trackstates_gsf_refit.root: 462b749ba0df395e1ca0e7d6f104077d3ca4c1297d7aadf5ca2b5bbc282bb617
test_refitting[generic]__tracksummary_gsf_refit.root: 94fad00ab0aa9f380a85135f89a81cc2e8761ab402d821a8af854e381f4982fc
test_refitting[generic]__tracksummary_gsf_refit.root: 5c9d2ccaf10597d716c771f04d692c437204469abed84bdff5c800c89e648625
test_refitting[odd]__trackstates_gsf_refit.root: e297749dc1e7eda3b8dea13defa0499986c584740d93e723a901b498b8e90c71
test_refitting[odd]__tracksummary_gsf_refit.root: d5085882e45a0b699194dff9f40a36e9291227bf65f9aaaf9087f9242ef5ae22
test_refitting[odd]__tracksummary_gsf_refit.root: cb905ac442be45f8c139f6903264dda480a91f273daba6bd92b49ad62d9e35f4
test_truth_tracking_kalman[generic-0.0]__trackstates_kf.root: eba0b055e4f8e3e30dae2e27ef662f213fe4fc9a5c9ed00e44adb86e7219e068
test_truth_tracking_kalman[generic-0.0]__tracksummary_kf.root: 94fad00ab0aa9f380a85135f89a81cc2e8761ab402d821a8af854e381f4982fc
test_truth_tracking_kalman[generic-1000.0]__trackstates_kf.root: 85d397a24d5546d580bd5c69fa60655d78db7392915ed67343717e99885f97d9
Expand Down
6 changes: 3 additions & 3 deletions Examples/Scripts/Python/truth_tracking_gsf_refitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def runRefittingGsf(
s.addWriter(
acts.examples.RootTrackSummaryWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="gsf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "tracksummary_gsf_refit.root"),
Expand All @@ -86,9 +86,9 @@ def runRefittingGsf(
s.addWriter(
acts.examples.TrackFitterPerformanceWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="gsf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="track_particle_matching",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "performance_gsf_refit.root"),
)
)
Expand Down
6 changes: 3 additions & 3 deletions Examples/Scripts/Python/truth_tracking_kalman_refitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def runRefittingKf(
s.addWriter(
acts.examples.RootTrackSummaryWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="kf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "tracksummary_kf_refit.root"),
Expand All @@ -83,9 +83,9 @@ def runRefittingKf(
s.addWriter(
acts.examples.TrackFitterPerformanceWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="kf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="track_particle_matching",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "performance_kf_refit.root"),
)
)
Expand Down
Loading