Specify transforms to Isometries

acts-project · Jan 29, 2025 · f5c5a5e · f5c5a5e
1 parent e6050dc
commit f5c5a5e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Plugins/GeoModel/src/GeoModelDetectorObjectFactory.cpp b/Plugins/GeoModel/src/GeoModelDetectorObjectFactory.cpp
@@ -163,7 +163,7 @@ void Acts::GeoModelDetectorObjectFactory::convertFpv(
 
   for (const auto &surface : surfaces) {
     const Transform3 &transform =
-        fpv->getAbsoluteTransform() * surface.transform;
+      fpv->getAbsoluteTransform() * Eigen::Isometry3d(surface.transform);
     convertSensitive(surface.volume, transform, sensitives);
   }
   cache.sensitiveSurfaces.insert(cache.sensitiveSurfaces.end(),

diff --git a/Plugins/GeoModel/src/GeoModelToDetectorVolume.cpp b/Plugins/GeoModel/src/GeoModelToDetectorVolume.cpp
@@ -126,7 +126,7 @@ Volume convertVolume(const Transform3& trf, const GeoShape& shape) {
         dynamic_cast<const GeoShapeShift*>(&shape);
     const GeoShape* shapeOp = shiftShape->getOp();
     newTrf = trf * shiftShape->getX();
-    return convertVolume(newTrf, *shapeOp);
+    return convertVolume(Eigen::Isometry3d(newTrf), *shapeOp);
   } else {
     throw std::runtime_error("FATAL: Unsupported GeoModel shape: " +
                              shape.type());

diff --git a/Plugins/GeoModel/src/detail/GeoBoxConverter.cpp b/Plugins/GeoModel/src/detail/GeoBoxConverter.cpp
@@ -33,7 +33,7 @@ Acts::detail::GeoBoxConverter::operator()(const PVConstLink& geoPV,
   // Create the surface transform
   Transform3 transform = Transform3::Identity();
   transform.translation() = unitLength * absTransform.translation();
-  RotationMatrix3 rotation = absTransform.rotation();
+  RotationMatrix3 rotation = absTransform.linear();
   // Get the half lengths
   std::vector<double> halfLengths = {geoBox.getXHalfLength(),
                                      geoBox.getYHalfLength(),