-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added text-shadow failure - Text has minimum contrast [afw4f7] #2184
Merged
WilcoFiers
merged 8 commits into
develop
from
giacomo-petri-minimum-contrast-text-shadow-failure
Aug 30, 2024
Merged
Added text-shadow failure - Text has minimum contrast [afw4f7] #2184
WilcoFiers
merged 8 commits into
develop
from
giacomo-petri-minimum-contrast-text-shadow-failure
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jym77
approved these changes
Apr 25, 2024
kengdoj
approved these changes
Jun 13, 2024
WilcoFiers
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked this over with Carlos earlier this week. I think a better example here would be one that shows text-shadow actually creating a failure, rather than one where text-shadow can be ignored.
WilcoFiers
approved these changes
Aug 1, 2024
carlosapaduarte
approved these changes
Aug 1, 2024
giacomo-petri
added
the
Review call 2 weeks
Call for review for new rules and big changes
label
Aug 1, 2024
2 weeks call for review ends on August 16th. |
colabottles
approved these changes
Aug 3, 2024
WilcoFiers
deleted the
giacomo-petri-minimum-contrast-text-shadow-failure
branch
August 30, 2024 08:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2172
Often, there's a misunderstanding that including a text-shadow property automatically ensures that text will have a satisfactory contrast ratio with its background.
To dispel this notion, I've provided an example where the text-shadow property fails to guarantee adequate contrast, contrasting with the Passed Example 4, to emphasize that relying solely on text-shadow doesn't always ensure sufficient contrast.
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve