Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form-field-label-descriptive-cc0f0a.md #2052

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions _rules/form-field-label-descriptive-cc0f0a.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,17 @@ This rule applies to any [programmatic label][] of an element which has one of t
- `switch`
- `textbox`

and where both the element and the [programmatic label][] are [visible][].
## Expectation 1

## Expectation
Each test target has a [programmatic label][].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: I don't think that works as an expectation, or at least that means the rule doesn't map to 2.4.6 anymore.
Firstly, 2.4.6 does not require label, only that if the exist they are descriptive (Understanding 2.4.6):

This Success Criterion does not require headings or labels. This Success Criterion requires that if headings or labels are provided, they be descriptive.

Secondly, 2.4.6 is about "WCAG labels" which are not restricted to programmatic ones, here also the Understanding document is explicit:

This Success Criterion also does not require that content acting as a heading or label be correctly marked up or identified - this aspect is covered separately by 1.3.1: Info and Relationships.


So, requiring a "WCAG label" is for 3.3.2, requiring that it is correctly marked up is for 1.3.1 (and a bit 4.1.2) and requirinig that it is descriptive is for 2.4.6.

We may be able to have a single rule with secondary requirements, but it seems that several rules for checking these different aspects would be better suited.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jym77 I am good with removing the expectation if that would fix this. Or another solution that fits better with this is also something I am good with as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this expectation won't fix it. 2.4.6 is Inapplicable to form fields without label (programmatic or not).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. As I'm unsure as to my status coming up, I'm good with what the group decides per the conversation.


Each test target, together with its [visual context][], describes the purpose of the associated element.
## Expectation 2

Each programmatic label from Expectation 1, together with its [visual context][], describes the purpose of the associated element and where both the element and the [programmatic label][] are [visible][].

## Assumptions

- This rule assumes that [labels][label] are intended for sighted users, and that hiding a [visible][] [label][] from assistive technologies, is a failure of [Success Criterion 4.1.2: Name, Role and Value][sc412], but not of [Success Criterion 2.4.6: Headings and Labels][sc246].
- This rule assumes that the [programmatic labels][programmatic label] of an element are also part of its [visual context][].
This rule assumes that the [programmatic labels][programmatic label] of an element are also part of its [visual context][].

## Accessibility Support

Expand Down