-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update form-field-label-descriptive-cc0f0a.md #2052
Open
colabottles
wants to merge
1
commit into
develop
Choose a base branch
from
colabottles-patch-1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: I don't think that works as an expectation, or at least that means the rule doesn't map to 2.4.6 anymore.
Firstly, 2.4.6 does not require label, only that if the exist they are descriptive (Understanding 2.4.6):
Secondly, 2.4.6 is about "WCAG labels" which are not restricted to programmatic ones, here also the Understanding document is explicit:
So, requiring a "WCAG label" is for 3.3.2, requiring that it is correctly marked up is for 1.3.1 (and a bit 4.1.2) and requirinig that it is descriptive is for 2.4.6.
We may be able to have a single rule with secondary requirements, but it seems that several rules for checking these different aspects would be better suited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jym77 I am good with removing the expectation if that would fix this. Or another solution that fits better with this is also something I am good with as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this expectation won't fix it. 2.4.6 is Inapplicable to form fields without label (programmatic or not).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. As I'm unsure as to my status coming up, I'm good with what the group decides per the conversation.