This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Fix edge case in range syntax sugar #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
force-pushed
the
fix-gen-secret-sugar
branch
from
23c6764 to
c662458
Compare
|
Just thought of some problems with this fix. Fixing the fix now. |
njhale
force-pushed
the
fix-gen-secret-sugar
branch
from
c662458 to
23a4f3b
Compare
Treat mixed case and backwards ranges (e.g. `A-z`, `0-A`, `z-a`) as individual characters in the given set. This simplifies the UX and makes ranges easier to reason about. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
fix-gen-secret-sugar
branch
from
23a4f3b to
ef36bde
Compare
StrongMonkey
approved these changes
Oct 17, 2023
tylerslaton
approved these changes
Oct 17, 2023
keyallis
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat mixed case and backwards ranges (e.g.
A-z,0-A,z-a) asindividual characters in the given set. This simplifies the UX and
makes ranges easier to reason about.