Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Ensure that the status.Defaults.VolumeSize is used if a binding has no size specified #2254

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

tylerslaton
Copy link
Contributor

This fixes an issue where, if a binding had nothing set in appSpec.Volumes the static size would always be used instead of status.Defaults.VolumeSize.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@tylerslaton tylerslaton requested review from thedadams, njhale and g-linville and removed request for thedadams October 17, 2023 16:41
@tylerslaton tylerslaton force-pushed the fix-qr-volume-binding branch from aaa8731 to 1169975 Compare October 18, 2023 17:16
@tylerslaton tylerslaton merged commit 649d0c9 into acorn-io:main Oct 18, 2023
@tylerslaton tylerslaton deleted the fix-qr-volume-binding branch October 18, 2023 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants