Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

handle dev clone on nested acorns (#2247) #2252

Merged
merged 2 commits into from
Oct 17, 2023
Merged

handle dev clone on nested acorns (#2247) #2252

merged 2 commits into from
Oct 17, 2023

Conversation

keyallis
Copy link
Contributor

@keyallis keyallis commented Oct 16, 2023

#2247

BuildContext changes pulled from Darren's example PR: #2251

Verified manually.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Copy link
Member

@cjellick cjellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good and is what we talked about. Give me a little more time to see where Darren wants to go with the feature.

@keyallis keyallis merged commit be8054c into acorn-io:main Oct 17, 2023
4 checks passed
@keyallis keyallis deleted the issue-2247 branch October 17, 2023 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants