This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Add range syntax sugar for secret generation #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
thedadams,
iwilltry42,
keyallis,
g-linville and
tylerslaton
tylerslaton
approved these changes
Oct 16, 2023
Comment on lines
+14
to
+33
| { | ||
| name: "A-Z", | ||
| want: "ABCDEFGHIJKLMNOPQRSTUVWXYZ", | ||
| }, |
There was a problem hiding this comment.
Can we add a test case for empty ranges being passed too? Mainly to make certain we don't have any chance of hitting an out of bounds panic.
njhale
force-pushed
the
gen-secret-sugar
branch
from
8f76b49 to
0b83294
Compare
Add the ability to specify ranges "A-Z", "a-z", and "0-9" when providing arguments for basic and token type secrets. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
gen-secret-sugar
branch
from
0b83294 to
13e1586
Compare
StrongMonkey
approved these changes
Oct 16, 2023
tylerslaton
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify ranges "A-Z", "a-z", and "0-9" when providing
arguments for basic and token type secrets.