This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Fix an issue with default VolmeStorage not being accounted for in QuotaRequests #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taRequests Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
volume-storage-quota
branch
from
72fbac2 to
f61c3f3
Compare
tylerslaton
requested review from
thedadams,
njhale,
StrongMonkey and
g-linville
tylerslaton
commented
Oct 12, 2023
| // if it does fail, we'll just return the default size. | ||
| parsedQuantity, err := resource.ParseQuantity(string(defaultVolume.Size)) | ||
| if err == nil { | ||
| result = parsedQuantity |
There was a problem hiding this comment.
This felt like the right behavior to me if a size failed to parse, but let me know if something else makes more sense.
thedadams
reviewed
Oct 12, 2023
| // 2. The volume's size is not set. This means we should assume the default size. | ||
| // 3. The volume's size is set to a specific value. This means we should use that value. | ||
| var sizeQuantity resource.Quantity | ||
| switch size { |
There was a problem hiding this comment.
It looks like the size of bound volumes are counted here. Is there any risk that we are double-counting bound volumes? Or are we saying you can have as many volumes as you want as long as none of them are bound?
There was a problem hiding this comment.
Talked offline about this, there's some wonky-ness with the boundVolumeSize function that we'll need to address. We came to the conclusion that this should merge as is and a follow-up should be created to fix it.
thedadams
approved these changes
Oct 13, 2023
njhale
approved these changes
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we were not accounting for the scenario that the Volume will receive a default size. This caused a number of issues regarding approval of resources.
Checklist
This is a title (#1216). Here's an example