Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Fix for quota requests not being processed (#1378) #2232

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

thedadams
Copy link
Contributor

@thedadams thedadams commented Oct 9, 2023

This change does three things:

  1. Updates the baaah dependency to fix a race condition during controller start. This was affecting quota requests.
  2. Changes an import name that was slightly confusing.
  3. Changes the determination of checking if quota is enforced from checking namespaces (the old way) to checking project instances (the new way).

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Issue: https://github.com/acorn-io/manager/issues/1378

This change does three things:
1. Updates the baaah dependency to fix a race condition during
controller start. This was affecting quota requests.
2. Changes an import name that was slightly confusing.
3. Changes the determination of checking if quota is enforced from
checking namespaces (the old way) to checking project instances (the new
way).

Signed-off-by: Donnie Adams <[email protected]>
@thedadams thedadams merged commit 1fc37ec into acorn-io:main Oct 9, 2023
4 checks passed
@thedadams thedadams deleted the bump-baaah-af2b68361b8a branch October 9, 2023 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants