change: cosmetic changes as per pr review comments

Signed-off-by: Thorsten Klein <[email protected]>

integration/client/imagerules/imageroleauthorizations_test.go

@@ -476,7 +476,7 @@ func TestImageRoleAuthorizationConsumerPerms(t *testing.T) {
 		return obj.Status.Staged.PermissionsChecked
 	})
 
-	require.Equal(t, 1, len(serviceAcorn.Status.Staged.ImagePermissionsDenied), "should have 0 denied permissions")
+	require.Equal(t, 1, len(serviceAcorn.Status.Staged.ImagePermissionsDenied), "should have 1 denied permissions")
 
 	// Create IRA to allow service Acorn to have the permissions
 	ira := &adminv1.ImageRoleAuthorization{

pkg/controller/appdefinition/depends.go

@@ -56,9 +56,9 @@ func getDependencyAnnotations(app *v1.AppInstance, containerOrJobName string, de
 		}
 	}
 
-	consumerpermsok := len(app.Status.DeniedConsumerPermissions) == 0
+	consumerPermsOk := len(app.Status.DeniedConsumerPermissions) == 0
 
-	if !allReady || !consumerpermsok {
+	if !allReady || !consumerPermsOk {
 		result[apply.AnnotationCreate] = "false"
 		if !app.GetStopped() {
 			result[apply.AnnotationUpdate] = "false"

pkg/controller/appdefinition/pullappimage.go

@@ -29,7 +29,6 @@ type pullClient struct {
 	pull pullImageFunc
 }
 
-// pullAppImage
 func pullAppImage(transport http.RoundTripper, client pullClient) router.HandlerFunc {
 	// NOTE: It is important that this logic does not interact with status.AppImage but instead
 	// status.Staged.AppImage