fix: login: eliminate possible nil dereference (#2445)

Signed-off-by: Grant Linville <[email protected]>
acorn-io · Jan 20, 2024 · 07b2490 · 07b2490
1 parent e2b69a6
commit 07b2490
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pkg/login/login.go b/pkg/login/login.go
@@ -21,7 +21,9 @@ func Secrets(ctx context.Context, c client.Client, app *apiv1.App) (*apiv1.App,
 			if err != nil {
 				return nil, err
 			}
-			app = updatedApp
+			if updatedApp != nil {
+				app = updatedApp
+			}
 		}
 	}
 
@@ -88,15 +90,14 @@ func bindSecret(ctx context.Context, c client.Client, app *apiv1.App, targetSecr
 	appName := parts[0]
 	targetSecretName = strings.Join(parts[1:], ".")
 
-	updatedApp, err := c.AppUpdate(ctx, appName, &client.AppUpdateOptions{
+	return c.AppUpdate(ctx, appName, &client.AppUpdateOptions{
 		Secrets: []v1.SecretBinding{
 			{
 				Secret: overrideSecretName,
 				Target: targetSecretName,
 			},
 		},
 	})
-	return updatedApp, err
 }
 
 func createSecret(ctx context.Context, c client.Client, app *apiv1.App, secretName string) (*apiv1.App, error) {