Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add form database #3

Merged
merged 52 commits into from
Jul 30, 2023
Merged

Add form database #3

merged 52 commits into from
Jul 30, 2023

Conversation

EthanThatOneKid
Copy link
Collaborator

@EthanThatOneKid EthanThatOneKid commented Jul 2, 2023 •
edited
Loading

Introducing Form dataclass and database implementations InMemoryFormDatabase (unit testing) and JSONFormDatabase (development).

EthanThatOneKid and others added 25 commits July 3, 2023 09:04
@EthanThatOneKid
WIP
a50f02a
@EthanThatOneKid
Simplify Form dataclass
3fb068c 
- Simplify `Form` dataclass
- Rename `FormField` to `Question`
@EthanThatOneKid
Run formatter
27a6aa2
@EthanThatOneKid
Clean Form properties
1d7b257
@EthanThatOneKid
Introduce render_form
74edd62
@EthanThatOneKid
Add Pylance linting
f9a4e8c
@EthanThatOneKid
WIP: Fix lint errors
243b700
@EthanThatOneKid
Add response module
8f8debf
@EthanThatOneKid
WIP
f1a3aee
@EthanThatOneKid
WIP
77e9949
@EthanThatOneKid
WIP
4464d6d
@EthanThatOneKid
WIP
aa8d8f2
@EthanThatOneKid
WIP
b61c29f
@EthanThatOneKid
Merge branch 'form-db' of https://github.com/acmcsufoss/form into for…
d9b1b2e 
…m-db
@EthanThatOneKid
Add label to each form input
7002daf
@EthanThatOneKid
Add acmcsuf.com favicon
76b1bf2
@EthanThatOneKid
Remove questionTypeLabel
d4d0c0b
@EthanThatOneKid
Group each input into form-field class
b089020
@EthanThatOneKid
WIP
668d8dc
@EthanThatOneKid
Add pico.css, prefix localStorage with formID
fb891f3
@EthanThatOneKid @26samaahmed
Move all HTML utils into html_util.py
280a518 
Co-Authored-By: Sama Ahmed <[email protected]>
@EthanThatOneKid @26samaahmed
Follow up <280a518>
7ea7eed 
Co-Authored-By: Sama Ahmed <[email protected]>
@EthanThatOneKid @26samaahmed
More follow-up
df48047 
See: <280a518>.
Co-Authored-By: Sama Ahmed <[email protected]>
@EthanThatOneKid
WIP
df0094c
@26samaahmed
I added an endpoint.
9d29a07
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review July 30, 2023 18:23
26samaahmed
26samaahmed approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@26samaahmed 26samaahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Progress!

@EthanThatOneKid EthanThatOneKid merged commit 581e2ce into main Jul 30, 2023
@EthanThatOneKid EthanThatOneKid deleted the form-db branch July 30, 2023 18:26
This was referenced Jul 31, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@26samaahmed 26samaahmed 26samaahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EthanThatOneKid @26samaahmed