Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Rations - Improve Vehicle Watersource Actions #10676

Merged

Conversation

mrschick
Copy link
Contributor

When merged this pull request will:
Changes moved here from #10675.

  • Add water actions directly to the vehicle instead of the helper object if the vehicle has no custom "waterActionPosition".
    This was causing the helper object to be attached to the center of the vehicle, making the interaction almost impossible to access from the outside.
  • Allow accessing the water source of vehicles with no custom "waterActionPosition" from the inside.

Fix unreachable water actions on vehicles with no waterActionOffset
Allow water actions from within a vehicle with no waterActionOffset
@johnb432
Copy link
Contributor

* Allow accessing the water source of vehicles with no custom `"waterActionPosition"` from the inside.

I don't understand in which cases this is useful or wanted. Can you elaborate?

@mrschick
Copy link
Contributor Author

Basically to allow accessing of a water canister that is mounted inside of a vehicle (i.e: that in a Bradley), as opposed to water cargo with an exterior faucet like the IDAP truck.

@LinkIsGrim LinkIsGrim self-requested a review February 5, 2025 02:32
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically to allow accessing of a water canister that is mounted inside of a vehicle (i.e: that in a Bradley)

Personally I can't behind this at this moment in time, because I don't have an example to look at in game. I want to play around and see how it feels, because, to me, having the interaction be available when both outside and inside the vehicle feels off.

What do you think @LinkIsGrim?

Co-authored-by: johnb432 <[email protected]>
@mrschick
Copy link
Contributor Author

mrschick commented Feb 8, 2025

As a more concrete example: the idea for it first arose on a 24/7 mission of mine as the Takistani Army, with field rations enabled.
I added water bottles to all vehicle inventories as a backup, along with water storage via ACE 3DEN Options. On something like an open UAZ (or a BTR/BRDM for that matter), where a "water tank" would be accessible from within, this would allow replenishing from the vehicle itself on the move, without having to drink from bottles and then have to switch them out with the stored ones.

@rautamiekka
Copy link
Contributor

As a more concrete example: the idea for it first arose on a 24/7 mission of mine as the Takistani Army, with field rations enabled. I added water bottles to all vehicle inventories as a backup, along with water storage via ACE 3DEN Options. On something like an open UAZ (or a BTR/BRDM for that matter), where a "water tank" would be accessible from within, this would allow replenishing from the vehicle itself on the move, without having to drink from bottles and then have to switch them out with the stored ones.

Yeah, exactly. Even something cramped like the Soviet T-34 from the WW2 had enough space for a few regular 0.5-liter plastic water bottles to be rolling around (emphasis on 'rolling around', meaning being loose on the floor), and next to every vehicle since could handle even more, with many more easily storing something similar (but way smaller) to the fuel/water bladders 'Arma 3' already had, or alternatively something like the fuel canisters filled with water, which the game/mod already also had.

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Feb 8, 2025

What do you think @LinkIsGrim?

I don't mind it.

But I am lazy. @mrschick you got an example of a vanilla vehicle I can test this with? If not, change config of something in this branch and then change it back after approval.

@mrschick
Copy link
Contributor Author

mrschick commented Feb 8, 2025

No vanilla vehicle has water storage without having a faucet (requirement for inside interaction).
To test it you can place any light vehicle in the editor and give it water storage via ACE Options in 3DEN.

@mrschick
Copy link
Contributor Author

mrschick commented Feb 8, 2025

You can try it on the IDAP water truck, I just removed its faucet position config.

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Feb 8, 2025

It works. The offset removal didn't though.

/shrug

@PabstMirror PabstMirror added this to the 3.19.1 milestone Feb 8, 2025
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Feb 8, 2025
@LinkIsGrim LinkIsGrim merged commit 1fb128b into acemod:master Feb 9, 2025
3 checks passed
@mrschick mrschick deleted the feature/field-rations-veh-interact branch February 9, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants