Intermediate technical release (required for vidjil-server integration) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instruction of adding a new algorithm: 1. Create a new class derived from PairwiseBlockAligner (see src/algorithms/block_alignment/pairwise_block_aligner.hpp). 2. Implement your algorithm in this class. There is at least one example. 3. Add a new value to enum vj_finder::VJFinderConfig::AlgorithmParams::AlignerParams::AlignerAlgorithm (in the file src/vj_finder/vj_finder_config.hpp). 4. Add detection of your algorithm to the config parser in function get_aligner_algorithm (in the file src/vj_finder/vj_finder_config.cpp). 5. Add creation of your class to function VJQueryAligner::get_aligner (in the file src/vj_finder/vj_query_aligner.cpp). 6. Finally, you may now change the algorithm used by igrec in the config configs/vj_finder/config.info (even though I'm not pretty sure changes in it are commited now).
Vjf improvement + profiling
This reverts commit d1fd5a7.
This reverts commit b4dce26.
This reverts commit 6d6cf2e.
VJQueryProcessor is now created only one time per thread
Igquast update
Add .vidjil output (required for integration with vidjil-server)
Vidjil format support minor fixup
.vidjil export: use reversed ranks as top values
Add summer version of AntEvolo
Chushuhuch
reviewed
Jul 4, 2018
| else: | ||
| input_file_tmp = None | ||
|
|
||
| # TODO this should be done automatically but it is not. Submit a bug |
There was a problem hiding this comment.
Submit it plz. It cannot be found here till next century.
Chushuhuch
approved these changes
Jul 4, 2018
| @@ -479,6 +479,8 @@ def __error_positions(self, tau=1, size=5, | |||
| result.sort() | |||
| return result | |||
|
|
|||
| # FIXME cons_size/ref_size args are probably swapped. Check and fix if | |||
| # necessary | |||
| @@ -479,6 +479,8 @@ def __error_positions(self, tau=1, size=5, | |||
| result.sort() | |||
| return result | |||
|
|
|||
| # FIXME cons_size/ref_size args are probably swapped. Check and fix if | |||
| # necessary | |||
# Conflicts: # CMakeLists.txt # igrec.py # src/vj_finder/vj_query_aligner.hpp # src/vj_finder/vj_query_processing.cpp
# Conflicts: # configs/.gitignore # src/vj_finder/vj_finder_config.cpp # src/vj_finder/vj_query_aligner.cpp # src/vj_finder/vj_query_aligner.hpp # src/vj_finder/vj_query_processing.cpp # src/vj_finder/vj_query_processing.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.