chore: minor code cleanup #134
Conversation
… defer in forloop
There was a problem hiding this comment.
Thank you very much for this PR! I left a note, and I had some feedback on the commit structure. We use rebases and smaller specific commits on this project. Looking at this PR I'd like to see it split up into several independent commits:
- Change the const naming convention
- fmt.Errorf -> errors.New
- copyFile refactor to avoid defer in loop
- res var vs. assignment
- use os.FileMode
- Reuse err rather shadow it
If you don't have time to do the rearranging, let me know and we can help take care of it.
| @@ -19,47 +20,47 @@ type ValidatorInfo struct { | |||
| } | |||
|
|
|||
| func (i *ValidatorInfo) Check() error { | |||
| if len(i.Name) > MAX_SHORT_FIELD_LENGTH { | |||
| return fmt.Errorf("name exceeds maximum length of %d", MAX_SHORT_FIELD_LENGTH) | |||
| if utf8.RuneCountInString(i.Name) > MaxShortFieldLength { | |||
There was a problem hiding this comment.
Hmm, I haven't looked, but have you double checked that the validator length limits are based on UTF-8 runes, rather than just bytes?
There was a problem hiding this comment.
Validations are attempting to mimic agave cli.
https://github.com/anza-xyz/agave/blob/master/cli/src/validator_info.rs#L35
|
Hey @tomiok just a bump on this. Let me know if you don't have the bandwidth, and we can take care of merging most of these changes in. Thanks. |
_ remove re assignation in errors
_ do not use defer inside a for loop by extracting in other func
_ replace fmt.Errorf with errors.New since the err was only a string.