Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ‘TIOCSTI’ undeclared error on MSYS2 #132

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

rashil2000
Copy link
Contributor

@rashil2000 rashil2000 commented Sep 1, 2021

This value seems to be undefined in MSYS2 environments.

Needs to be manually defined.

Reference - dvorka/hstr@79781c1

@rashil2000 rashil2000 changed the title Fix ‘TIOCSTI’ undeclared error on Cygwin/MSYS2 Fix ‘TIOCSTI’ undeclared error on MSYS2 Sep 1, 2021
@abishekvashok
Copy link
Owner

Seems good. Can someone with Cygwin help by doing a quick test of this path?

@rashil2000 this is no way an underestimation of this patch. I appreciate and thank you for the time you put into this issue. Thank you for working on it. I really want to get this merged however, I don't have any way of testing this.

I can merge this if someone, even you, tests this on Cygwin and reports whether this mitigates the issue. (Just to be sure)

@rashil2000
Copy link
Contributor Author

Well, I went through the (painful) setup of installing Cygwin. The TIOCSTI error is gone now, but the LINES and COLS issue (elaborate discussion here #40) still persists. No idea how to solve that :(

I have renamed this PR to remove the mention of Cygwin, since it fixes only the MSYS2 issue.

@rashil2000
Copy link
Contributor Author

Hey @abishekvashok, sorry for pinging but, is there anything that needs to be done for this PR?

@abishekvashok abishekvashok merged commit 3112b12 into abishekvashok:master Sep 20, 2021
@rashil2000 rashil2000 deleted the cygwin-fix branch September 20, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants