Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kocherga_serial: update header format #26

Merged
merged 3 commits into from
Apr 4, 2024
Merged

kocherga_serial: update header format #26

merged 3 commits into from
Apr 4, 2024

Conversation

coderkalyan
Copy link
Contributor

Fixes #22

@pavel-kirienko
Copy link
Member

I think it is best to move CRCs into the common header -- kocherga.hpp -- because they will be used in the Cyphal/UDP transport as well. Maybe there are some other common parts here.

@coderkalyan
Copy link
Contributor Author

Ok, will do. I'll ping you when it's actually ready, tests aren't passing right now.

@coderkalyan coderkalyan force-pushed the update-serial-header branch from 94c3902 to 5fc7c84 Compare March 30, 2024 06:54
@coderkalyan coderkalyan marked this pull request as ready for review March 30, 2024 06:55
@coderkalyan
Copy link
Contributor Author

@pavel-kirienko This should be ready for review now. Sorry it took so long.

pavel-kirienko
pavel-kirienko requested changes Mar 30, 2024
View reviewed changes
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into the build issues. I think the CI should run automatically now; let me know if it doesn't.

kocherga/kocherga.hpp Outdated Show resolved Hide resolved
kocherga/kocherga_serial.hpp Outdated Show resolved Hide resolved
kocherga/kocherga_serial.hpp Outdated Show resolved Hide resolved
kocherga/kocherga_serial.hpp Outdated Show resolved Hide resolved
kocherga/kocherga_serial.hpp Outdated Show resolved Hide resolved
tests/unit/serial/test_misc.cpp Outdated Show resolved Hide resolved
tests/unit/serial/test_stream.cpp Outdated Show resolved Hide resolved
@coderkalyan coderkalyan force-pushed the update-serial-header branch from 5fc7c84 to 4097a57 Compare April 1, 2024 05:06
@coderkalyan
Copy link
Contributor Author

@pavel-kirienko I don't think the CI is running automatically.

@pavel-kirienko
Copy link
Member

I don't think the CI is running automatically.

ok it should now

@coderkalyan coderkalyan force-pushed the update-serial-header branch from 4097a57 to 3614021 Compare April 1, 2024 18:22
@coderkalyan coderkalyan force-pushed the update-serial-header branch from 3614021 to 08546d7 Compare April 1, 2024 18:36
@coderkalyan
Copy link
Contributor Author

Thanks, everything is good now except for sonarcloud (not sure what's wrong exactly, but doesn't seem to be related to the code).

pavel-kirienko
pavel-kirienko approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar is slightly misconfigured because the SONAR_TOKEN is not exported for pull request builds and also because it runs on an old Java version. It is safe to ignore that for now.

Please see my latest comments and then we can merge it.

tests/unit/serial/test_misc.cpp Outdated Show resolved Hide resolved
@coderkalyan
Copy link
Contributor Author

Thanks. Just pushed the updated test.

@pavel-kirienko pavel-kirienko merged commit 4395519 into Zubax:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-kirienko pavel-kirienko pavel-kirienko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Cyphal/serial header format
2 participants
@coderkalyan @pavel-kirienko