Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/m1 fixes #3

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Feat/m1 fixes #3

merged 3 commits into from
Nov 20, 2024

Conversation

neithanmo
Copy link
Collaborator

This PR includes the following updates:

  • Refactored Code: Removed duplicated code by utilizing the generic Ledger JS package for handling error responses and enhanced FVK type definitions.
  • Path Validation: Added validation to throw errors when an incorrect path is provided, along with necessary comments.
  • Address Indexing: Introduced address indexing functionality.

@neithanmo
Copy link
Collaborator Author

will merge after testing some missing parts

@neithanmo
Remove duplicated code by using our generic ledger js package to hand…
b9c0286 
…le error response function and improve FVK type definition

fix subarray offset
@neithanmo neithanmo merged commit eab2942 into master Nov 20, 2024
2 checks passed
@neithanmo neithanmo deleted the feat/m1_fixes branch November 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

@abenso abenso abenso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neithanmo @emmanuelm41 @abenso