-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added helper function to get modification time from git #409
Conversation
Check out the preview on https://409.pr.zeus.gent/ |
fbc76e8 shows: |
e4dc936
to
804c0b1
Compare
804c0b1 shows |
as mentioned in #96
|
@mcbloch There's still an issue with this fix. A lot of posts now show an incorrect writing date, such as the following: I think this should be reverted and reopened. |
I think just removing the “created at” part of the pr I made was not a good idea. I can look into this later when I have some time. Is there a documented way to add test to this repo? So a test can pick up a regression like this? |
No custom tests yet, but should be easy enough to add using nanoc's checks: https://nanoc.ws/doc/testing/ |
@JensTimmerman maybe use the first date the file was created instead of the last time? |
@redfast00 can this be discussed in #265 ? I have asked a few questions on how you want to see edge cases handled in that issue I believe the time the blog was merged makes more sense than the time a file with that name was created? since that is the original question in that issue |
fixes #265