Add a new Chobby skin + icon refresh

[completesomething]

This PR reskins Chobby to be a bit more modern, using the Evolved skin as a base.

For now, every skin-related change is currently stored within the Evolved skin to easily rebase and check what exactly has been changed. When the PR is ready, these changes will moved to a new skin.

DO NOT MERGE UNTIL THEY'RE MOVED TO A NEW SKIN FOLDER

Feel free to nitpick or make suggestions.

Preview (the below preview is out-of-date, see #861 (comment) for an updated preview.)

[completesomething]

Elements of this new skin could possibly be reused for a future in-game UI reskin.

There was originally a plan to have a drop shadow for the main two large panels, but this plan was dropped for consistency and somewhat technical reasons, as the floating buttons on the left and top-right would need drop shadows as well. A drop shadow shader, if possible, would be the cleanest solution.

Button and panel images were made in Krita. Icons were mostly made in Inkscape. I'm not sure about how I'd license them yet.

[GoogleFrog]

Looks good. Just on this screenshot.

• Should the battle list have the same border as the windows on the right?
• The border colour seems a bit bright to me, at least in the lower right regions where it is contrasting with the dark part of the gradient. A gradient on the border doesn't seem good or viable. Maybe the gradient is too strong or the borders could be tweaked less bright,
• Is the host game and discord button the same colour? The bottom buttons seems a bit too accentuated?
• The lobby news headings have a darker background, which seems bad.
• Filter out and password appear to have misaligned.
• The bottom right of the battle list window gets quite dark.

On sources.

• The license has to be pretty permissive because this sort of stuff needs ending in the future.
• Sources etc need to be committed because otherwise the lobby art becomes write-only.

[completesomething]

* Should the battle list have the same border as the windows on the right?

If you're referring to the 1-pixel border, I'll investigate.

* The border colour seems a bit bright to me, at least in the lower right regions where it is contrasting with the dark part of the gradient. A gradient on the border doesn't seem good or viable. Maybe the gradient is too strong or the borders could be tweaked less bright,

Sure. I've tweaked the main panel gradient to be very subtle now:

Currently uncommitted. It could be even lighter.

* Is the host game and discord button the same colour? The bottom buttons seems a bit too accentuated?

They're the same color/class. What you're observing might be due to the bright color of the Discord button contrasting with the darker gradient of the background.

* The lobby news headings have a darker background, which seems bad.

One of those loose ends. I'll look into it.

* Filter out and password appear to have misaligned.

This is due to the font shadow for some reason. I'll probably remove the font shadows for that kind of text.

* The bottom right of the battle list window gets quite dark.

Check above screenshot.

* The license has to be pretty permissive because this sort of stuff needs ending in the future.
* Sources etc need to be committed because otherwise the lobby art becomes write-only.

Permissive licensing, sure.

For sourcing the icons and the main panels, sure. For the buttons, some source files will be missing because I didn't bother saving much sources during the experimentation phase.

[GoogleFrog]

Is this supposed to be WIP still?

[GoogleFrog]

To clarify, I don't tend to look at or review WIPs in much detail. When it is done enough to not be "WIP" I poke through it more thoroughly and probably clone it locally.

[completesomething]

Is this supposed to be WIP still?

There are still things I want to fix, yes.

[completesomething]

The icon refresh portion of the work is basically finished within the scope I was planning, but I haven't licensed them yet.

[completesomething]

This PR is ready for review now.

For reference, current Evolved:

My revised Evolved:

Do not merge until these are changes are moved to a new skin folder.

Should the battle list have the same border as the windows on the right?

I think it's fine. The battle buttons and their layout serve a different purpose, and the welcome screen looks bare without the borders.

The lobby news headings have a darker background, which seems bad.

I think this is fine. They help indicate that they are link buttons, and they also serve as faux separators, so the headings would look bare without it.

[GoogleFrog]

Chat tabs in single panel mode are missing background.

[GoogleFrog]

Chat text box colour isn't the same as the boxes that hold player names and chat. Battle room and chat channels.

Idk if this is inherently bad, but seems like a weird/accidental choice at least.

[GoogleFrog]

Do clickable things always need to be dark like this? I can see the argument. But it makes the surrounding grey look a bit off/dirty.

[GoogleFrog]

The grey in general seems to make things a bit messier/harder to read. It has lower contrast.

[GoogleFrog]

How thoroughly was the increased width for these buttons tested? I could see the testing being a pain.

I see the change was a bit more than just a scale. What was it and why?

[GoogleFrog]

The top battle status is too blue when the battle is selected. Actually this feedback probably extends to the main menu buttons as well. I am not sure about having a blue box sit on the edge of the screen all the time. Seems a bit noisy.

[GoogleFrog]

The tickboxes seem ambiguous. Looking at it twice this feedback surprises me. But when I first looked at this page i just got a feeling of not knowing whether the box was selected or not.

[GoogleFrog]

I see the change was a bit more than just a scale. What was it and why?

I recalled how the top status area deals with small screens. This means there is no reason for tabs to get so squished that Downloads hangs off the edge.

[GoogleFrog]

Overall is seems a bit cleaner. The buttons are crisper. The gradients on the main panel and battle rooms seem a bit strong, they get pretty dark towards the bottom right. The number of shades of white used make it feel a bit messy on a few screens.

Personally I don't see what is wrong with decorated borders. Not everything needs to be a flat grey gradient.

There are also a bunch of alignment things to touch up. Eg with exit.

[GoogleFrog]

This looks better to me. Flat black with a border has better contrast, doesn't overuse grey, and the borders add interest.

[GoogleFrog]

Minor comments:

• Why are MM battles red? To me that indicates people shouldn't click on them. Surely passworded battles would be red if anything?
• The button behind the minimap has a gradient on it. It probably shouldn't, since it is acting more as a container for non-square maps (like black bars on movies/videos) than a standard button.
• Chat and settings lines don't align when switching between the tabs. They should, I suspect this is preexisting though.

[completesomething]

New changes, including addressing the majority of the above issues:

• Replaced the bottom link button images in the Welcome/Profile tabs with something less bright and eye-catching. See end of comment.
• Modified the large main windows to have very subtle and smoother gradients. I'd really rather not compromise more than that.
• Reverted the checkboxes to their stable state.
• Normalize padding of main windows.
• Gave tabbar items proper BKs and FGs so that they show better in single pane mode. As a consequence, the selected tab is now brighter instead of darker.
• Adjusted battle button colors, swapping red with violet, decreasing opacity of red, and slightly increasing opacity of green/yellow buttons.
• Since the top right buttons are now relationally scaled like in BAR Chobby, lessened the button widths and replaced some titleWidths with titleWidthRel to ensure proper padding. Reverted top right button scaling to stable behavior as this caused additional problems.
• Made selected button colors less bright.
• Differentiated selected color of button and highlight_button to keep the battle room playing/spectating button fairly bright.
• Adjusted loading screen stars to slightly fade out downward.
• Tweaked trackbar height and color.

Chat text box colour isn't the same as the boxes that hold player names and chat.

Intentional.

There are also a bunch of alignment things to touch up.

I've adjusted the main panel padding which should have address the majority of alignment issues. There's still minor mispadding of the Close buttons which is a bit of a different problem, but I don't think it should be blocking.

Chat and settings lines don't align when switching between the tabs. They should, I suspect this is preexisting though.

This is existing behavior and I don't think it's a problem that should be fixed. The settings tabs are bigger as they're more important to most users.

Do clickable things always need to be dark like this?
The grey in general seems to make things a bit messier/harder to read.
The button behind the minimap has a gradient on it.

I feel these particular points are rather subjective and arguable. I don't think they should be blocking issues unless others agree that they are problems.

The new link buttons:

[GoogleFrog]

Are you force pushing this or something? Removing the commit history makes this unnecessarily hard to pull and keep track of what is going on.

[GoogleFrog]

This is existing behavior and I don't think it's a problem that should be fixed. The settings tabs are bigger as they're more important to most users.

The lines, not the tabs at the top.

[GoogleFrog]

Updated preview

[GoogleFrog]

To revisit this, I don't think the undecorated grey gradient brackground is working. Numerous people think the old border and flat back background looks better so I think we should just stick with it. Besides, the alignment of buttons and panels still needs updating for the new background anyway.