Skip to content

Commit

Permalink
Upgrade node to 18 (#270)
Browse files Browse the repository at this point in the history
* Upgradinge base node version to 18
* Correcting launching firebase in ci
  • Loading branch information
pierre-nicoli authored Dec 15, 2023
1 parent 85ebc01 commit 09fb683
Show file tree
Hide file tree
Showing 5 changed files with 4,684 additions and 6,091 deletions.
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ parameters:
executors:
default:
docker:
- image: cimg/node:16.15.1
- image: cimg/node:18.19.0
environment:
GOOGLE_APPLICATION_CREDENTIALS: google_application_credentials.json

Expand All @@ -30,8 +30,8 @@ commands:
- run:
name: Install << parameters.package-name >>
command: |
npm install --global \
<< parameters.package-name >>@$(node --print --eval='require("./package-lock.json").packages["node_modules/<< parameters.package-name >>"].version') \
npm install \
<< parameters.package-name >>@$(node --print --eval='require("./package-lock.json").packages["node_modules/<< parameters.package-name >>"].version') \
setup-firebase-auth:
parameters:
firebase-project:
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
firebase-project: << parameters.firebase-project >>
- install-dependency-as-global-package:
package-name: firebase-tools
- run: firebase --project=<< parameters.firebase-project >> functions:config:get > config.json
- run: npx firebase --project=<< parameters.firebase-project >> functions:config:get > config.json
- run: npx [email protected] --required --noExtraProps --out config-schema.json functions/src/config.ts Config
- run: npx --package ajv-cli ajv validate -s config-schema.json -d config.json

Expand Down
2 changes: 1 addition & 1 deletion functions/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"typescript": "3.8.3"
},
"engines": {
"node": "16"
"node": "18"
},
"private": true
}
Loading

0 comments on commit 09fb683

Please sign in to comment.