Skip to content

Commit

Permalink
client: improve feedZback guide (#728)
Browse files Browse the repository at this point in the history
  • Loading branch information
avine authored Dec 11, 2024
1 parent 5a8ed9b commit e70e960
Show file tree
Hide file tree
Showing 64 changed files with 2,183 additions and 2,601 deletions.
12 changes: 6 additions & 6 deletions client/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@
},
{
"type": "anyComponentStyle",
"maximumWarning": "2.5kb",
"maximumError": "4kb"
"maximumWarning": "3kb",
"maximumError": "5kb"
}
],
"outputHashing": "all"
Expand All @@ -80,8 +80,8 @@
},
{
"type": "anyComponentStyle",
"maximumWarning": "2.5kb",
"maximumError": "4kb"
"maximumWarning": "3kb",
"maximumError": "5kb"
}
],
"outputHashing": "all",
Expand All @@ -101,8 +101,8 @@
},
{
"type": "anyComponentStyle",
"maximumWarning": "2.5kb",
"maximumError": "4kb"
"maximumWarning": "3kb",
"maximumError": "5kb"
}
],
"outputHashing": "all",
Expand Down
2 changes: 1 addition & 1 deletion client/e2e/pages/give-requested-feedback.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class GiveRequestedFeedbackPage {
'Feedback receiver should be filled in correctly',
).toHaveValue(persona);

await this.page.getByText('Points positifs').fill(details.positive);
await this.page.getByText('Points forts').fill(details.positive);
await this.page.getByText("Axes d'améliorations").fill(details.negative);
await this.page.getByText('Commentaire').fill(details.comment);

Expand Down
2 changes: 1 addition & 1 deletion client/e2e/pages/give-spontaneous-feedback.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class GiveSpontaneousFeedbackPage {
async give(persona: Persona, details: Details) {
await this.page.getByLabel('Email de votre collègue').fill(persona);

await this.page.getByText('Points positifs').fill(details.positive);
await this.page.getByText('Points forts').fill(details.positive);
await this.page.getByText("Axes d'améliorations").fill(details.negative);
await this.page.getByText('Commentaire').fill(details.comment);

Expand Down
Loading

0 comments on commit e70e960

Please sign in to comment.