fix(mining): Advertise mined blocks #9176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
added
A-network
arya2
previously approved these changes
Jan 31, 2025
There was a problem hiding this comment.
This looks great, thank you for these changes. It's more complicated than what I had in mind, but it makes it easy to now handle mined blocks differently and broadcast them to all ready peers instead of a third of them.
I opened a suggestion PR, #9183, for your review. Ideally this PR could advertise mined blocks immediately and return early from check_synced_to_tip() on test networks, but I see no blockers to merging this as-is.
* refactor error conversions in GetBlockTemplateRpcImpl and rewords documentation * Replaces polling mined block receiver with a select * Skip checking that Zebra is likely synced to the network tip before returning block templates on Testnet. * fixes a clippy lint and a concurrency bug
arya2
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When blocks are mined and we are not close to the tip the mined block do not get advertised to the network.
Close #8909
Solution
Introduce a channel with a sender part used by the rpc method submit block to add a signal when a block is submitted and accepted. The receiver part of the channel is used by the block gossip task to advertise the block.
Tests
submitblock_channelwas added to check the gossip task can receive mined blocks.nu6_funding_streams_and_coinbase_balanceto make sure the sender part of the channel is working.PR Author's Checklist
PR Reviewer's Checklist