-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details to README (#339) #3
Conversation
Create Makefile commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I would just add some more details about exactly how to build and run the demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks! I think it just needs addressing Pili's comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes look good, but I noticed some other issues, sorry for not noticing them in the first pass.
Co-authored-by: Conrado Gouvea <[email protected]>
I added in more things based on the suggestions, so this wasn't there the first time round :-) |
Co-authored-by: Conrado Gouvea <[email protected]>
Looks good to me, waiting for @mpguerra 's approval |
Adds content to README
Creates Makefile commands
This closes #339