Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: performance improve, fix minor aria and disaplay bugs #90

Merged
merged 3 commits into from
Dec 11, 2024
Merged

chore: performance improve, fix minor aria and disaplay bugs #90

merged 3 commits into from
Dec 11, 2024

Conversation

ZL-Asica
Copy link
Owner

Chore:

  • Remove thumbnailAbout and thumbnailFriends options from config, enable showThumbnail option for frontmatter for each page to use.
  • Change all icons to use fa6 instead of others to reduce bundling size.
  • Remove not-exist prop onLinkClick from useTOCLogic hook.

Fix:

  • Aria issue with TOC, use menu instead of nav. Use ul + li instead of div.
  • TOC link switch to barebone <a> tag instead of nextjs Link components to avoid prefetch cost performance.
  • Auto slug activate may exceed viewport and not centered even possible.

Deps:

  • Upgrade nextjs to 15.1.0
  • Remove engine part since controlled by packageManager and node-version

@ZL-Asica ZL-Asica added bug Something isn't working enhancement New feature or request labels Dec 11, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suzu-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:21am

@ZL-Asica ZL-Asica merged commit e40be9c into main Dec 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working common-components content enhancement New feature or request main services size/M types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ZL-Asica