Added commonly used method #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return $result; | ||
| } | ||
|
|
There was a problem hiding this comment.
The indentation is totally messed up.
There was a problem hiding this comment.
It's been 2 years since I posted this, I am not sure if the PR is still relevant.
There was a problem hiding this comment.
If we haven't needed it up to this point, it's probably best to close it anyway. Any modules using ZfcBase have implemented this themselves already.
There was a problem hiding this comment.
I retract my prior statement...it would be nice to have this, but implemented like this:
/**
* @return ResultSetInterface
*/
public function findAll()
{
return $this->select($this->getSelect());
}
Together with #64, this would remove the necessity for ZfcUserAdmin\Mapper\ZendDbMapper::findAll
|
@Danielss89 this can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.