Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autobackup update #6695

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

PTR-inc
Copy link
Contributor

@PTR-inc PTR-inc commented Jan 14, 2025

Added an option to configure the hour during which the autobackup should be done instead of being determined by the service start time to have more control if wanted.

There is also the extra logging for #6675. I tried to replicate the issue, but it worked every time, on windows and linux.
Hopefully the extra logging will help to determine the issue.
Debug logging for the backup was under the 'db' category, moved it to the 'backup' debug category to keep it clean.

Add "debug": "backup" to the config.json for extra logging besides the default start and file removal logging of the autobackup.

@PTR-inc
Copy link
Contributor Author

PTR-inc commented Jan 15, 2025

Found the path bug for #6675, adding the fix and testing

@PTR-inc PTR-inc marked this pull request as draft January 15, 2025 21:26
@PTR-inc PTR-inc marked this pull request as ready for review January 20, 2025 13:28
@PTR-inc
Copy link
Contributor Author

PTR-inc commented Jan 20, 2025

So, added some extra messages within the backup process. Normally only backup success will be logged. If you do an autobackup from the console a bit more info is given. If the debug level 'backup' is added, the logging will be even more.
Added an extra file create test to the backupcompatibility check.
And moved error messages to the error log for optional convienent split logging if needed.

The bug was in using an absolute path in the backuppath parameter of the autobackup. Tested on windows & linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant