handler must fire resolve if it fired for create #106
Conversation
Yelp#103 handler should now fire a resolve if the event was triggered for create action earlier. handler should not fire a resolve if the event was not triggered for create action earlier.
files/base.rb
Outdated
| @@ -229,6 +229,18 @@ def filter_repeated | |||
|
|
|||
| initial_failing_occurrences = interval > 0 ? (alert_after / interval) : 0 | |||
| number_of_failed_attempts = @event['occurrences'] - initial_failing_occurrences | |||
| # sensu 0.26+ only, else never make occurrences_watermark actionable | |||
| occurrences_watermark = @event.key?('occurrences_watermark') ? event['occurrences_watermark'] : -1 | |||
There was a problem hiding this comment.
I would put all of your logic into if @event.key?('occurrences_watermark') instead of assigning it a phony value of -1.
files/base.rb
Outdated
| # occurrences_watermark > initial_failing_occurrences prove enough occurrences | ||
| # of the event that triggered create and hence it is safe to filter the event to resolve handler action. | ||
| if occurrences_watermark > initial_failing_occurrences and @event['action'] == 'resolve' | ||
| return nil |
There was a problem hiding this comment.
What's your reasoning behind putting all this code in filter_repeated method? And could you please confirm that returning nil from filter_repeated is somehow significant - in other words, could you please clarify why you are returning nil here.
There was a problem hiding this comment.
I'm guessing because that's the style further down in this method where the exponential back off returns nil to exit the method and indicate "ok to process". I think both locations could probably just use return as that's effectively the same thing. further nuance, while the tests are looking for nil I think any return that doesn't call #bail would allow the event to be processed.
if power_of_two?(number_of_failed_attempts)
# Then This is our MOMENT!
return nil
else
|
@solarkennedy @somic style changes made. |
|
Lets do it |
#103
handler should now fire a resolve if the event was triggered
for create action earlier.
handler should not fire a resolve if the event was not triggered
for create action earlier.