Add bindings for Rock Band and Riffmaster guitar solo buttons #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feedback on the shader effect stuff in the last couple of commits would be greatly appreciated. |
|
This has been updated to use an object for solo effects. All shader stuff relating to solos has also been removed. The engine modifier icon is not yet final and I'm sure changes to the texture on the solo object will be required, but I believe the code is in a good enough state to merit review. |
wyrdough
changed the title
wyrdough
force-pushed
the
fivefret-solo
branch
2 times, most recently
from
f0704c3 to
201ec87
Compare
An interim icon was added to the ModifierIcons sprite sheet to support this change.
wyrdough
force-pushed
the
fivefret-solo
branch
from
62cad56 to
f4a17fa
Compare
wyrdough
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bindings for solo buttons as found on Rock Band guitars and the Riffmaster and changes the default bindings for those devices to bind solo buttons as solo buttons instead of regular buttons.
See YARG.Core PR #224 for engine support.
Related graphical effects are included in #936