[ Feature/dev 112] 문제풀기 Floating Button 구현 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happhee
approved these changes
Sep 21, 2024
| const viewportHeight = window.innerHeight; | ||
| const documentHeight = document.documentElement.scrollHeight; | ||
|
|
||
| // Hide button only if the user reaches the bottom of the page |
There was a problem hiding this comment.
어디선가 로직을 가져온것이냐...아니면 숨니의 영어실력..? ㅋㅎㅋㅎㅋㅎ진실을 알려줘!
| // }); | ||
| }; | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
이안에서 function ~ 함수명 으로 컨벤션 맞춰주시면 좋을 것 같아요!
| className={cn( | ||
| "h-[55px] px-5 py-3.5 bg-[#264932] rounded-[99px] shadow flex justify-center items-center gap-2" | ||
| )} | ||
| onClick={onClickGoProblem} |
There was a problem hiding this comment.
button type 명시해주면 시멘틱스러울 것 같습니다!
| return ( | ||
| <> | ||
| {showButton && ( | ||
| <div className="fixed bottom-[48px] left-[60%] z-10 w-fit"> |
There was a problem hiding this comment.
혹시 여기 bottom은 px로 하고 left는 %로 사용하신 이유가 있을 까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
https://linear.app/fewletter/issue/DEV-112/%EC%95%84%ED%8B%B0%ED%81%B4-%EB%AC%B8%EC%A0%9C%ED%92%80%EC%9D%B4-%ED%94%8C%EB%A1%9C%ED%8C%85-%EB%B2%84%ED%8A%BC
💜 작업 내용
👀 스크린샷 / GIF / 링크